Merged
Conversation
my32_pthread_attr_setaffinity_np() was passing the raw attr wrapper pointer directly to the native pthread_attr_setaffinity_np() instead of using get_attr(attr) to extract the native pthread_attr_t pointer. This bug existed since the initial Box32 commit (b5105a1). All other pthread_attr_* functions in threads32.c correctly use get_attr(attr).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my32_pthread_attr_setaffinity_np() was passing the raw attr wrapper pointer directly to the native pthread_attr_setaffinity_np() instead of using get_attr(attr) to extract the native pthread_attr_t pointer.
This bug existed since the initial Box32 commit (b5105a1). All other pthread_attr_* functions in threads32.c use get_attr(attr).