Skip to content

[BOX32][WRAPPER] Fix XRRGetPanning shrinking wrong variable#3521

Merged
ptitSeb merged 1 commit intoptitSeb:mainfrom
devarajabc:0218_22
Feb 17, 2026
Merged

[BOX32][WRAPPER] Fix XRRGetPanning shrinking wrong variable#3521
ptitSeb merged 1 commit intoptitSeb:mainfrom
devarajabc:0218_22

Conversation

@devarajabc
Copy link
Contributor

@devarajabc devarajabc commented Feb 17, 2026

Lines 67-68 were operating on res (XRRScreenResources* input) instead of ret (XRRPanning* return value), corrupting the input struct instead of shrinking the returned panning data.
it should be like this:

  32-bit app calls XRRGetPanning(dpy, res_32, crtc)                                                                                                                                                       
          │                                                                  
          ▼
  my32_XRRGetPanning:
    1. enlarge res (32-bit → 64-bit)     ← convert input for native call
    2. call native XRRGetPanning(dpy, res_64, crtc)
    3. shrink res (64-bit → 32-bit)      ← restore input to 32-bit form
    4. shrink ret (64-bit → 32-bit)      ← convert output for 32-bit caller
    5. return ret_32
          │
          ▼
  32-bit app gets back XRRPanning* in 32-bit layout

Lines 67-68 were operating on res (XRRScreenResources* input)
instead of ret (XRRPanning* return value), corrupting the input
struct instead of shrinking the returned panning data.
@ptitSeb ptitSeb merged commit 0fed9f3 into ptitSeb:main Feb 17, 2026
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments