Skip to content

Add pulp_ansible git remotes#1440

Merged
mdellweg merged 1 commit into
pulp:mainfrom
ATIX-AG:ansible_git_remote
Jul 13, 2026
Merged

Add pulp_ansible git remotes#1440
mdellweg merged 1 commit into
pulp:mainfrom
ATIX-AG:ansible_git_remote

Conversation

@quba42

@quba42 quba42 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

I am hoping it is easier to add this, than it is to talk directly to the API for more than 5 minutes...

@quba42

quba42 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

I have manually tested this change against the workflow described here: pulp/pulp_ansible#2565

All commands using pulp ansible remote --type git ... that I have tried so far have worked.

@quba42
quba42 force-pushed the ansible_git_remote branch from 4a72d0d to 350c0ff Compare July 10, 2026 13:58
@quba42
quba42 marked this pull request as ready for review July 13, 2026 07:20
@quba42 quba42 changed the title WIP: Add pulp_ansible git remotes Add pulp_ansible git remotes Jul 13, 2026

@mdellweg mdellweg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i read this correctly, it does not depend on the pulp_ansible pr, you opened, but it's supposed to help dealing with it.

@mdellweg
mdellweg merged commit e23ab62 into pulp:main Jul 13, 2026
17 checks passed
@quba42
quba42 deleted the ansible_git_remote branch July 13, 2026 11:09
@quba42

quba42 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

If i read this correctly, it does not depend on the pulp_ansible pr, you opened, but it's supposed to help dealing with it.

You read that correctly. What this PR does is to expand the pulp ansible remote --type flag to accept the argument git. What my PR does is expand the functionality of pulp_ansible git remotes so they no longer ignore what the user supplied for "username" and "password". Pulp CLI does not have to care whether pulp_ansible ultimately does anything useful with the API parameters, it just needs to use the API interface correctly. Which it will do without my PR in pulp_ansible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants