Open
Conversation
This moves generalisation and globalisation for value signatures only after value equations are checked. This addresses an issue where kind variables that get solved in the equation body are generalised too early in the previous implementation.
This demonstrates a current limitation in the type checker where operators poiinting to kind-polymorphic value groups infer to an incorrect type. This issue can be addressed by deferring generalisation for operator declarations, much like it is now for value declarations.
Record patterns that mention different subsets of a row type produced rows of unequal width in the specialisation matrix, causing a panic in default_matrix. Normalise all record constructors to the union of labels before specialising, padding missing labels with wildcard patterns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test case demonstrates unification errors that come from failed promote_type checks when trying to solve unification variables against rigid type variables that came from the instance head canonical.
This fixes the 228 test case by introducing a proper instantiation step for rigid type variables from the instance head canonical. This creates fresh rigid type variables with update depths, fixing issues with the escape check in promote_type and subsequently, unification. This also changes the representation of Bindings::implicit to be based on Vec instead of HashMap. This enables trivial shadowing, ensuring that implicit type variables are kept up to date after instantiation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this branch is to be able to compile the core packages; the
compiler-compatbilitycrate provides a utility that shows compilation errors for each module in the package. There's still a very long journey ahead.