Draft
Conversation
Signed-off-by: Adam Li <adam2392@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage ? 22.08%
=======================================
Files ? 6
Lines ? 240
Branches ? 31
=======================================
Hits ? 53
Misses ? 186
Partials ? 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robertness
reviewed
Apr 26, 2023
| n_shuffle: int = 100, | ||
| random_seed: Optional[int] = None | ||
| ) -> PValueResult: | ||
| rng = np.random.default_rng(random_seed) |
robertness
reviewed
Apr 26, 2023
| n_shuffle: int = 100, | ||
| random_seed: Optional[int] = None | ||
| ) -> PValueResult: | ||
| rng = np.random.default_rng(random_seed) |
robertness
reviewed
Apr 26, 2023
| val = hxyz - (hxz + hyz - hz).mean() | ||
| return val | ||
|
|
||
| def _preprocess_data(self, data: pd.DataFrame) -> pd.DataFrame: |
Collaborator
There was a problem hiding this comment.
robertness
reviewed
Apr 26, 2023
| _, indices = nbrs.kneighbors(z_arr) | ||
| elif method == "kdtree": | ||
| tree_xyz = scipy.spatial.cKDTree(z_arr) | ||
| indices = tree_xyz.query(z_arr, k=k, p=np.inf, eps=0.0, workers=n_jobs)[1].astype(np.int32) |
Collaborator
There was a problem hiding this comment.
else: return ValueError
robertness
reviewed
Apr 26, 2023
| rng = np.random.default_rng(seed=random_seed) | ||
|
|
||
| # initialize the final permutation order | ||
| restricted_perm = np.zeros((n_samples,)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| restricted_perm = np.zeros((n_samples,)) | |
| restricted_perm = np.zeros((n_samples,), dtype=np.int32) |
robertness
reviewed
Apr 26, 2023
| if it has not been used to permute another sample. If it has been, then the | ||
| algorithm looks at the next nearest-neighbor and so on. If all k-nearest | ||
| neighbors of a sample has been checked, then a random neighbor is chosen. In this | ||
| manner, the algorithm tries to perform permutation without replacement, but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards: #5
Changes proposed in this pull request:
This is still a draft.
Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.After submitting