ble/sagas: Don't read NUS for new firmware.#2358
Merged
laurensvalk merged 1 commit intomasterfrom Jan 23, 2026
Merged
Conversation
Member
|
Since all of the tests are passing, I think this should be OK. And given that we are going the AppData direction, I think it is OK to remove this from the firmware. No one has been asking to connect their NUS device to Pybricks hubs, and at the same time people seem OK with implementing Pybricks Profile on their ESP32. |
Member
Author
|
Thanks for having a look. Indeed. And between Spike hubs, we'll soon have RFCOMM for streaming data when BLE advertising doesn't cut it. |
This hasn't been used for a long time in Pybricks Code. We're only keeping it in the firmware because Pybricks Code raises an error otherwise. Disabling it saves about +400 bytes on Move Hub and Technic Hub and helps simplify the firmware. By removing it we don't run untested code if someone connects to the advertised NUS service.
044efb6 to
39d43f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NUS hasn't been used for a long time in Pybricks Code. We're only keeping it in the firmware because Pybricks Code raises an error if a hub doesn't have it.
Disabling it saves about +400 bytes on Move Hub and Technic Hub and helps simplify the firmware. By removing it we don't run untested code if someone connects to the advertised NUS service that isn't internally wired up to anything.
This is a draft/proposal. Not entirely sure if there are other pieces of the code that need changing too.
This is actually just a 3-line diff if you discount the indent changing.