Do not wait forever for test server to start or stop#1037
Open
akx wants to merge 2 commits into
Open
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
|
Thanks, but we already have #994 merged which makes sure the test select an available port instead of the overused port 8000 |
Author
|
@mbeijen Great! The fix here is still relevant though: don't wait forever if there's an issue, and surface other exceptions :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I was wondering why the test suite just hung forever, and finally with
pytest tests/ -vvvx --log-cli-level=DEBUG -sI found that:– yep, I was working on something else on port 8000 – and so,
server.runningnever becomesTrue, and tests just hang.This PR:
server.run()(in the secondary thread) are caught and propagated immediately to the controlling loopPort of PR encode/httpx#3775
Checklist