Ensure mounted transports are closed even if main transport raises#1070
Open
mbeijen wants to merge 1 commit into
Open
Ensure mounted transports are closed even if main transport raises#1070mbeijen wants to merge 1 commit into
mbeijen wants to merge 1 commit into
Conversation
If a client with proxy mounts fails to close the main transport (its close()/__exit__/aclose()/__aexit__ raises), the mounted transports were never reached, leaking their connections. Wrap the main transport cleanup in try/finally so mounts are always closed regardless. Ported from encode/httpx#3769.
Merging this PR will not alter performance
Comparing Footnotes
|
mbeijen
added a commit
to mbeijen/httpx2
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a client with proxy mounts fails to close the main transport (its close()/exit/aclose()/aexit raises), the mounted transports were never reached, leaking their connections. Wrap the main transport cleanup in try/finally so mounts are always closed regardless.
Ported from encode/httpx#3769.