Fix direct URL dependencies not stored in lockfile #6502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5967
When a package has an extra dependency with a direct URL using PEP 508 syntax (e.g.,
my-package @ https://server.com/my-package-1.0.0.whl), the URL was not being stored in the lockfile. This caused pipenv to fall back to searching PyPI for the package, which would fail if the package is only available at the private URL.Root Cause
In
pipenv/utils/locking.py, theformat_requirement_for_lockfilefunction only checked forreq.link.is_file(which only matchesfile://URLs), but not for remote HTTP/HTTPS URLs:For a remote URL like
https://my-private-artifactory-url/.../my-private-dependency-1.0.0.whl,is_filereturns False (it only returns True forfile://scheme URLs), so the URL was never stored in the lockfile.Fix
Added handling for
httpandhttpsschemes, storing the URL in thefilekey of the lockfile entry (same asfile://URLs):Tests
Added unit tests for:
Pull Request opened by Augment Code with guidance from the PR author