Open
Conversation
…s download latest postgres version
merging upstream branch
change nodejs version to 8
- make async the default method, since sync parsing is probably a bad idea. - have sync throw on errors, to mirror the promise rejecting - return/resolve with the result, rather than an object with a query property.
Also fixes a bug where something wasn’t getting freed properly in the old logic, causing the code to hang if the callback to our async functions called `resolve()` from an outer promise.
1. Preserve dirs needed for build. I didn’t want to keep the compiled artifacts in these directories in the repo (since they get overwritten on install anyway, and are platform dependent), but the directories do need to be there for our current build script — which could just create them, but this is easier. 2. Build pg and the parser with min Mac version matching node-gyp's setting. This is needed to prevent an error when linking. 3. Point to a slightly-improved version of the parser, with richer nodes.
The published version for 1.2.0 didn’t quite match the code on Github.
pyramation
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.