This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Fix audit findings from rules review#39
Merged
Merged
Conversation
- Fix 3 bare signal reads in counter template: {count} → {() => count()}
- Fix link.tsx ref type: HTMLElement → HTMLAnchorElement, remove as any
- Fix architecture.md middleware signature to match actual API
- Fix code-style.md: add onUnmount to lifecycle hooks list
Zero as any in codebase.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from auditing the codebase against its own rules:
{count}→{() => count()})as any— properRef<HTMLAnchorElement>in link.tsxonUnmountto code-style.md lifecycle hooksZero
as anyremaining in codebase. All rules consistent with implementation.🤖 Generated with Claude Code