Fix type hints of assert functions#1271
Conversation
Updated type hints in assert functions to use Iterable instead of Collection. And have assertRaisesMessage return something to use as a context manager.
There was a problem hiding this comment.
LGTM, looks like you got it from here 😉 ah, right you added it in your description, eek. As you can see, I read code first then descriptions... foot, meet mouth. 😇
|
Seems low risk. Merging. |
|
@kingbuzzman Could you generate a new patch release with this fix soon? This is otherwise blocking the upgrade to 4.12 for my projects. |
|
@brianhelba unfortunately, i do not possess such powers. @bluetech |
|
Hum, if you want a release, can you make another PR and change the changelog please. This would go a long way in getting the release ready. Thats on me, I should have asked for this in the first place. |
Add changelog entry for pytest-dev#1271 for next version
See #1271. Although someone will have to update it once the release date is known |
* Add changelog entry Add changelog entry for #1271 for next version * Apply suggestion from @mschoettle * Apply suggestion from @mschoettle
Updated type hints in assert functions to use Iterable instead of Collection. And have assertRaisesMessage return something to use as a context manager.
This is in line with
django-stubs: https://github.com/typeddjango/django-stubs/blob/master/django-stubs/test/testcases.pyiVersion 4.12.0 raises the following errors with
mypy: