fix: Tolerate 500-errors on calendar existtence probing#8
Open
fix: Tolerate 500-errors on calendar existtence probing#8
Conversation
Introduced a `_calendar_is_accessible(cal)` static method on `CheckMakeDeleteCalendar` that probes a calendar by calling `.events()` and catches `DAVError` (which covers `NotFoundError` 404, `AuthorizationError` 403, and `ReportError` 500). This replaces three inline try/except blocks that had inconsistent exception coverage — one caught `Exception` (too broad), two caught only `NotFoundError` (too narrow). The trigger was a server that returns HTTP 500 on a REPORT request for a non-existent calendar, reported at pycalendar/calendar-cli#114 (comment) Also simplified `_try_make_calendar` to return a plain `bool` instead of a `(bool, exception_or_None)` tuple; callers only ever used `[0]`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a
_calendar_is_accessible(cal)static method onCheckMakeDeleteCalendarthat probes a calendar by calling.events()and catches
DAVError(which coversNotFoundError404,AuthorizationError403, andReportError500).This replaces three inline try/except blocks that had inconsistent
exception coverage — one caught
Exception(too broad), two caughtonly
NotFoundError(too narrow). The trigger was a server that returnsHTTP 500 on a REPORT request for a non-existent calendar, reported at
pycalendar/calendar-cli#114 (comment)
Also simplified
_try_make_calendarto return a plainboolinsteadof a
(bool, exception_or_None)tuple; callers only ever used[0].Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com