Conversation
icalendar_searcher.Searcher.check_component() mutated include_completed from None to False (for todo searches) as a side-effect on the first search() call. Subsequent calls would then take the include_completed=False code path (with server clone + three-hacks approach) instead of the simpler else-branch used for include_completed=None. This caused inconsistent results when reusing a CalDAVSearcher object across multiple search() calls. The fix passes a copy with include_completed already resolved to filter_search_results(), leaving the original CalDAVSearcher unchanged. Also removes the post_filter=True workaround from testSearchForRecurringTask (it was no longer needed; the auto-setting logic handles it correctly). Fixes #650 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
icalendar_searcher.Searcher.check_component() mutated include_completed from None to False (for todo searches) as a side-effect on the first search() call. Subsequent calls would then take the include_completed=False code path (with server clone + three-hacks approach) instead of the simpler else-branch used for include_completed=None. This caused inconsistent results when reusing a CalDAVSearcher object across multiple search() calls.
The fix passes a copy with include_completed already resolved to filter_search_results(), leaving the original CalDAVSearcher unchanged.
Also removes the post_filter=True workaround from testSearchForRecurringTask (it was no longer needed; the auto-setting logic handles it correctly).
Fixes #650