Skip to content

Make Ukrainian locale name follow ISO 639, update it and add tests - #957

Merged
Secrus merged 4 commits into
python-pendulum:masterfrom
nykula:master
Aug 20, 2026
Merged

Make Ukrainian locale name follow ISO 639, update it and add tests#957
Secrus merged 4 commits into
python-pendulum:masterfrom
nykula:master

Conversation

@nykula

@nykula nykula commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Fixes #955.

@codspeed-hq

codspeed-hq Bot commented Apr 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 1 untouched benchmark


Comparing nykula:master (fd45ad8) with master (cbab60c)

Open in CodSpeed

Comment thread tests/localization/test_uk.py
ashb
ashb previously requested changes Apr 8, 2026
Comment thread src/pendulum/locales/uk/locale.py
Comment thread tests/localization/test_uk.py
Comment thread tests/localization/test_uk.py
Comment thread src/pendulum/locales/locale.py Outdated
@nykula

nykula commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

My bad, left the updated test file uncommitted.

@Secrus
Secrus enabled auto-merge (squash) August 20, 2026 13:02
@Secrus
Secrus disabled auto-merge August 20, 2026 13:03
@Secrus
Secrus dismissed ashb’s stale review August 20, 2026 13:03

Blocks merging

@Secrus
Secrus merged commit 0d71391 into python-pendulum:master Aug 20, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ukrainian locale should be uk not ua

4 participants