Skip to content

There is a disjunction between the linting step in the CI and actually developing for the oldest supported python version. #818

Description

@ThosRTanner

The CI linting step runs on python 3.12. This means that changes can be made that can make it impossible to lint on earlier versions of python (As of today, I can no longer run black in a python3.8 environment for instance).

This actually makes it difficult to safely develop for older environments because you might make a change to the code that is valid on python3.12 but will fail on an older environment - something you're unlikely to catch until the CI fails in a peculiar fashion and then you have to work

Specifically I'm asking for the black changes to be reverted so it actually still works on python3.8, or we drop support for both python 3.8 and 3.9, but please also make the linting step of the CI run on the oldest supported python to reduce toil. And I think that black needs to be pinned to the same version no matter what the version of python in use is.

Pinging @ceache and @StephenSorriaux

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions