Skip to content

chore: use cryptography package instead of openssl.crypto in tests - #823

Open
ThosRTanner wants to merge 1 commit into
python-zk:masterfrom
ThosRTanner:issue/782/use-diff-crypto-library
Open

ThosRTanner wants to merge 1 commit into
python-zk:masterfrom
ThosRTanner:issue/782/use-diff-crypto-library

Conversation

@ThosRTanner

Copy link
Copy Markdown
Contributor

Fixes #782

Why is this needed?

Stops us moving to later versions of openssl module

Proposed Changes

  • Rip out all of openssl.crypto logic in testing/common.py and replace with cryptography calls

Does this PR introduce any breaking change?

No - this only affects testing

@ThosRTanner
ThosRTanner force-pushed the issue/782/use-diff-crypto-library branch from b3a64ba to 7f2db60 Compare September 18, 2026 17:09
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.96%. Comparing base (79cae1f) to head (7f2db60).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          27       27           
  Lines        3811     3811           
=======================================
  Hits         3619     3619           
  Misses        192      192           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyopenssl crypto is deprecated - should move to a new cryptography package (tests fail badly...)

1 participant