-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-142927: Tachyon: Comma separate thousands and fix singular/plurals #142934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'd like to suggest using a locale translation for separating numbers instead of using english-based values. I am personally always confused when commas are used to separate thousands and I think it's better if it's using a localized output. |
|
I disagree with the "Single file specialisation," IMO the plural sounds better and in general zero takes a plural noun form? |
Right now, the numbers are formatted in the Python script, and then put into the HTML. I guess one way would be to put unformatted numbers in the HTML and use some JS to do locale conversion in the browser? |
"x/y" is like saying "x of y", and it's the "y" that matters for the plural:
|
Can't we use localized messages? or maybe pass through locale.(...) for formatting numbers? |
|
Yes, and that's much simpler :) How does this 9cfd9ef look? |
|
It looks better (and simpler). For the "words" we can also use |
|
I'll let you open a followup if you'd like to localise the words :) |
I used the UX improvement issue (#142927) for this, but can change it to the main implementation one (#138122) or another.