gh-143089: Fix ParamSpec default examples to use list instead of tuple #143179
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
sobolevn
reviewed
Dec 25, 2025
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
There's another case of default=() in test_paramspec, please fix it as well.
Member
There was a problem hiding this comment.
No news entry is required for this change, please remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect ParamSpec default examples in the ParamSpec
docstring shown by help(ParamSpec).
According to the typing specification, ParamSpec defaults must be a list
literal, ellipsis (
...), or another ParamSpec. Tuples are not permitted.The docstring examples previously used tuple defaults. These are updated
to use list defaults to match the typing specification and the existing
documentation.
Closes: gh-143089