[docs] CONTRIBUTING.md: specify bare infinitive instead of imperative#19064
Open
wyattscarpenter wants to merge 1 commit intopython:masterfrom
Open
[docs] CONTRIBUTING.md: specify bare infinitive instead of imperative#19064wyattscarpenter wants to merge 1 commit intopython:masterfrom
wyattscarpenter wants to merge 1 commit intopython:masterfrom
Conversation
Technically, git commit subject lines are in the bare infinitive, not the imperative, because they're merely unconjugated, rather than being a command. (They are identical in form, though, so it's understandable that they were confused here.) Or, so I think, at least! For more information, you can see https://en.wikipedia.org/wiki/Bare_infinitive , https://en.wikipedia.org/wiki/Imperative_mood , or this blog post I wrote about this subject a while ago: https://wyattscarpenter.github.io/blog/git_commit_messages_are_in_the_bare_infinitive.txt
Collaborator
|
To my surprise I was familiar with both terms and the proposed wording is correct, but... IMO this is overly pedantic. There are a lot of contributors here who only speak very basic English. The term imperative should be familiar to them as it's just basic grammar, while bare infinitive may be less clear. I can easily imagine a commit/pr message "To prevent crash on a malformed input" because the author knows what infinitive means but never encountered bare infinitive before and therefore just skipped it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the git commit guidelines to say "Use the bare infinitive in the subject line" instead of "Use the imperative mood in the subject line"
Technically, git commit subject lines are in the bare infinitive, not the imperative, because they're merely unconjugated, rather than being a command. (They are identical in form, though, so it's understandable that they were confused here.)
Or, so I think, at least! For more information, you can see https://en.wikipedia.org/wiki/Bare_infinitive , https://en.wikipedia.org/wiki/Imperative_mood , or this blog post I wrote about this subject a while ago: https://wyattscarpenter.github.io/blog/git_commit_messages_are_in_the_bare_infinitive.txt