Skip to content

windows-release/tcltk-build: Update to handle Tcl/Tk 9#378

Open
zware wants to merge 2 commits intomainfrom
tcl9_fixups
Open

windows-release/tcltk-build: Update to handle Tcl/Tk 9#378
zware wants to merge 2 commits intomainfrom
tcl9_fixups

Conversation

@zware
Copy link
Copy Markdown
Member

@zware zware commented May 6, 2026

  • tcltk-build: Remove Tix
  • tcltk-build: Split {Tcl,Tk}SourceTag into version and prefix parameters

@zware zware requested a review from zooba May 6, 2026 19:21
@zooba
Copy link
Copy Markdown
Member

zooba commented May 6, 2026

Apart from the CI failure, looks good to me. I guess they need some better cross-compiling support, but hopefully you can override a build variable to get it to use the Win32 build during the ARM64 one?

@zware
Copy link
Copy Markdown
Member Author

zware commented May 6, 2026

Yep, looking into what else needs the override now.

@zooba
Copy link
Copy Markdown
Member

zooba commented May 8, 2026

Another trick we could use here is to extract the version number from the header file, that way we can go back to setting just the tags when building:

$ver = @{}
Get-Content .\generic\tcl.h | ?{ $_ -match '#\s*define\s+TCL_([A-Z]+)_VERSION\s+(\d+).*'} | %{ $ver[$Matches[1]] = $Matches[2] }
$ver.MAJOR
$ver.MINOR

That doesn't help people trying to build separately (without this script), but the current change doesn't help them either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants