[Flask-Cors] Update type annotation for origins to also allow Pattern#15825
[Flask-Cors] Update type annotation for origins to also allow Pattern#15825wvanbergen wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
ed1a6d6 to
555f3da
Compare
This comment has been minimized.
This comment has been minimized.
brianschubert
left a comment
There was a problem hiding this comment.
Thanks! See remarks below. This change looks good, but I'm noticing some inconsistencies with the previous annotations that we should fix while we're here.
|
@brianschubert I double-checked your suggestions, and they all makes sense, so committed your suggestions. Thanks! |
6b907c1 to
be55340
Compare
|
Something weird happened with the |
|
pre-commit indicates some problems with the line endings. Possibly some Windows-style line endings ( |
be55340 to
b1ea393
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This should be fixed now; I think this was an artifact of me using the Github UI to accept suggestions. |
Small fix: this updates the type annotation for the
originsargument forCORS()andCORS.init_appto also acceptPatterns. Also, useIterablerather thanlistto not cause compatibility issues.originsargument of thecross_origindecorator.