Add gss_localname and friends#374
Open
JacobHenner wants to merge 2 commits into
Open
Conversation
* gss_authorize_localname * gss_localname * gss_pname_to_uid * gss_userok Fixes pythongssapi#49 Signed-off-by: Jacob Henner <code@ventricle.us>
JacobHenner
force-pushed
the
feat/gss_localname-and-friends
branch
from
82c3132 to
39b3677
Compare
jborean93
reviewed
Jun 22, 2026
| @@ -0,0 +1,93 @@ | |||
| import typing as t | |||
|
|
|||
| if t.TYPE_CHECKING: | |||
Contributor
There was a problem hiding this comment.
Do we need this check, I don't think the names and oids files will need to import this ext file and we shouldn't need to use the t.TYPE_CHECKING conditional import.
Author
There was a problem hiding this comment.
I was following the pattern I observed in the other ext_*.pyi files within the same directory, but perhaps I've overlooked some other aspect that establishes the necessity for this block. What's the criteria for including/not including?
Comment on lines
+84
to
+85
| if isinstance(username, str): | ||
| username = username.encode(_utils._get_encoding()) |
Contributor
There was a problem hiding this comment.
Is there a benefit to accepting both bytes and str here? I would have thought we would just use bytes but it's been a while since I've looked at what some of the other functions are doing.
Not available on Windows. Include it conditionally to prevent build errors on Windows. Signed-off-by: Jacob Henner <code@ventricle.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49