Fix _upsample_bilinear2d_aa portable kernel correctness - #20733
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20733
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 2 Cancelled JobsAs of commit d052f55 with merge base 4af91c3 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
manuelcandales
approved these changes
Jul 8, 2026
manuelcandales
left a comment
Contributor
There was a problem hiding this comment.
Nicely done @arkadip-maitra
Thank you!
Contributor
Author
Hi @manuelcandales, thank you for the approval. I checked the lint failures and they seem unrelated to the 3 files changed in this PR, also the other failures seems unrelated. If that looks okay on your side would you prefer merging this PR or should I rebase first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13969
Fix _upsample_bilinear2d_aa portable kernel correctness for anti-aliased downsampling by removing the 4 tap contributor limit and matching PyTorch’s full support window.
Added portable tests and corrected tolerance in test file
cc @larryliu0820 @manuelcandales