Skip to content

Fix _upsample_bilinear2d_aa portable kernel correctness - #20733

Merged
manuelcandales merged 1 commit into
pytorch:mainfrom
arkadip-maitra:fix_13969
Jul 10, 2026
Merged

Fix _upsample_bilinear2d_aa portable kernel correctness#20733
manuelcandales merged 1 commit into
pytorch:mainfrom
arkadip-maitra:fix_13969

Conversation

@arkadip-maitra

@arkadip-maitra arkadip-maitra commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #13969

Fix _upsample_bilinear2d_aa portable kernel correctness for anti-aliased downsampling by removing the 4 tap contributor limit and matching PyTorch’s full support window.

Added portable tests and corrected tolerance in test file

cc @larryliu0820 @manuelcandales

@pytorch-bot

pytorch-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20733

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 2 Cancelled Jobs

As of commit d052f55 with merge base 4af91c3 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 5, 2026
@nil-is-all nil-is-all added module: kernels Issues related to kernel libraries and utilities, and code under kernels/ release notes: ops & kernels Changes to the opset and any new / changed kernel implementations labels Jul 8, 2026

@manuelcandales manuelcandales left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @arkadip-maitra
Thank you!

@arkadip-maitra

arkadip-maitra commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Nicely done @arkadip-maitra Thank you!

Hi @manuelcandales, thank you for the approval.

I checked the lint failures and they seem unrelated to the 3 files changed in this PR, also the other failures seems unrelated.

If that looks okay on your side would you prefer merging this PR or should I rebase first

@manuelcandales
manuelcandales merged commit 5869165 into pytorch:main Jul 10, 2026
202 of 211 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: kernels Issues related to kernel libraries and utilities, and code under kernels/ release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExecuTorch correctness failure for upsample_bilinear2d_aa

3 participants