Skip to content

[ExecuTorch][WebGPU] Test coverage for the packed-word-dequant f16 steel GEMM#20799

Merged
meta-codesync[bot] merged 6 commits into
gh/JCNTH/14/basefrom
gh/JCNTH/14/head
Jul 9, 2026
Merged

[ExecuTorch][WebGPU] Test coverage for the packed-word-dequant f16 steel GEMM#20799
meta-codesync[bot] merged 6 commits into
gh/JCNTH/14/basefrom
gh/JCNTH/14/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 9, 2026

Copy link
Copy Markdown

Stack from ghstack (oldest at bottom):

Locks the group_size % BK gate that selects the packed-word-dequant (pwdq) f16 steel GEMM. pwdq is bit-exact to the half kernel, so the existing steel_f16/steel_f16_edge configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:

  • test_quantized_linear.py / test_webgpu_native.cpp — add pwdq_gs64 (gs=64, % BK == 0 → stays on pwdq) and pwdq_gs8 (gs=8 < BK=16 → falls back to the per-nibble half kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the WGPU_BACKEND_STEEL_F16 build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
@exported-using-ghexport

Differential Revision: D111163551

Differential Revision: D111163551

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20799

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 12 Pending, 1 Unrelated Failure

As of commit fc07e9a with merge base f4b01a8 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • pull / android / build-android (gh) (trunk failure)
    ImportError: /opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/executorch/extension/training/pybindings/_training_lib.cpython-311-x86_64-linux-gnu.so: undefined symbol: _ZN3c104impl3cow23materialize_cow_storageERNS_11StorageImplE

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[ghstack-poisoned]
[ghstack-poisoned]

@SS-JIA SS-JIA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@meta-codesync meta-codesync Bot merged commit 1e1334c into gh/JCNTH/14/base Jul 9, 2026
175 of 183 checks passed
@meta-codesync meta-codesync Bot deleted the gh/JCNTH/14/head branch July 9, 2026 21:40
@meta-codesync meta-codesync Bot temporarily deployed to cherry-pick-bot July 9, 2026 21:41 Inactive
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
JCNTH added a commit that referenced this pull request Jul 9, 2026
…eel GEMM

Pull Request resolved: #20799

Locks the `group_size % BK` gate that selects the packed-word-dequant (`pwdq`) f16 steel GEMM. `pwdq` is bit-exact to the `half` kernel, so the existing `steel_f16`/`steel_f16_edge` configs (gs=32) already exercise it; these add the two group sizes the gate keys on but those omit.

Key changes:
- `test_quantized_linear.py` / `test_webgpu_native.cpp` — add `pwdq_gs64` (gs=64, `% BK == 0` → stays on `pwdq`) and `pwdq_gs8` (gs=8 `< BK=16` → falls back to the per-nibble `half` kernel, whose per-K scale read is correct there). Both goldened at the f16 tol (2.3e-4) in the `WGPU_BACKEND_STEEL_F16` build against the fp64 dequant-matmul truth.

Co-authored-with: Claude Code.
ghstack-source-id: 401564881
@exported-using-ghexport

Differential Revision: [D111163551](https://our.internmc.facebook.com/intern/diff/D111163551/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants