Skip to content

[ExecuTorch][WebGPU] Migrate 9 ops to make_compute_pipeline (layout:"auto")#20868

Open
JCNTH wants to merge 1 commit into
gh/JCNTH/43/basefrom
gh/JCNTH/43/head
Open

[ExecuTorch][WebGPU] Migrate 9 ops to make_compute_pipeline (layout:"auto")#20868
JCNTH wants to merge 1 commit into
gh/JCNTH/43/basefrom
gh/JCNTH/43/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 10, 2026

Copy link
Copy Markdown

Stack from ghstack (oldest at bottom):

Route add, mul, index, permute, select, slice, update_cache, rms_norm, and embedding_q4gsw through the shared utils::make_compute_pipeline helper (which uses layout:"auto"), replacing each op's hand-written WGPUBindGroupLayoutEntry[] + pipeline-layout + bind-group boilerplate (~50-110 lines each) with a single helper call. The driver now derives the bind-group layout from the shader's statically-used bindings. Byte-behavior is preserved: identical binding indices/types/buffers/sizes, dispatch workgroup counts, resize hooks, and validations; override constants (wg_size) passed via the helper's constants param. Extends the Diff 1 layout:"auto" adoption to the trivial single-dispatch ops.

Differential Revision: D110836665

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20868

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 5e7ab80 with merge base aceeb40 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants