Arm backend: Remove duplicate scratch allocation in Direct Drive - #22175
Merged
Conversation
Scratch was always allocated using the temporary allocator, even though Direct Drive allocated it itself in invoke_linux_driver. Introduce platform_allocate to let each platform decide for itself how to allocate memory. Some extra handling is needed around copying io, though this will be addressed properly in a later patch. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I4ae4afe6ae3a0ff3a5e85612f3f3f2b508f88599
Erik-Lundell
requested review from
digantdesai,
kirklandsign and
larryliu0820
as code owners
August 26, 2026 13:27
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22175
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit 0f280f1 with merge base 6ce2715 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
Hey @Erik-Lundell - just as an fyi, I've been working on a proof of concept for delegate scratch bufffers: #21985. |
Collaborator
Author
That looks great @rascani. I will drop the second commit of the PR and wait for your solution. |
Erik-Lundell
force-pushed
the
plan-ethosu-scratch
branch
from
August 26, 2026 14:39
88ea87a to
0f280f1
Compare
rascani
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.