Skip to content

Arm backend: Remove duplicate scratch allocation in Direct Drive - #22175

Merged
Erik-Lundell merged 1 commit into
pytorch:mainfrom
Erik-Lundell:plan-ethosu-scratch
Aug 27, 2026
Merged

Arm backend: Remove duplicate scratch allocation in Direct Drive#22175
Erik-Lundell merged 1 commit into
pytorch:mainfrom
Erik-Lundell:plan-ethosu-scratch

Conversation

@Erik-Lundell

@Erik-Lundell Erik-Lundell commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator
Scratch was always allocated using the temporary allocator, even
though Direct Drive allocated it itself in invoke_linux_driver.

Introduce platform_allocate to let each platform decide for itself
how to allocate memory. Some extra handling is needed around
copying io, though this will be addressed properly in a later patch.

Scratch was always allocated using the temporary allocator, even
though Direct Drive allocated it itself in invoke_linux_driver.

Introduce platform_allocate to let each platform decide for itself
how to allocate memory. Some extra handling is needed around
copying io, though this will be addressed properly in a later patch.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I4ae4afe6ae3a0ff3a5e85612f3f3f2b508f88599
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels Aug 26, 2026
@pytorch-bot

pytorch-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22175

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 0f280f1 with merge base 6ce2715 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Aug 26, 2026
@rascani

rascani commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Hey @Erik-Lundell - just as an fyi, I've been working on a proof of concept for delegate scratch bufffers: #21985.

@Erik-Lundell

Copy link
Copy Markdown
Collaborator Author

Hey @Erik-Lundell - just as an fyi, I've been working on a proof of concept for delegate scratch bufffers: #21985.

That looks great @rascani. I will drop the second commit of the PR and wait for your solution.

@Erik-Lundell Erik-Lundell changed the title Plan ethosu scratch Arm backend: Remove duplicate scratch allocation in Direct Drive Aug 26, 2026
@Erik-Lundell
Erik-Lundell merged commit e433b96 into pytorch:main Aug 27, 2026
502 of 507 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants