Open
Conversation
Treat blob ids as strings due to size limitations
Fix negative upvoteCount wrongly displayed
we don't really need them, do we?
Prevent using <embed> and <object> tags
Fire u_delete_before event before deleting a user
Prevent duplicated vote events
Collaborator
|
Haven't had a chance to review this properly yet, but just wanted to say this is a great area for improvement that we have neglected in the past. Thanks for the effort! The branch seems to have gotten a bit messed up, but I should be able to cherry-pick your commits when I get time. |
Author
|
Yeah, as said, I just tried to extract all the relevant things from our own project and made a PR out of it. Just ask if any changes are unclear. It's for sure a good idea to split this PR into smaller ones with definite topics like e.g. correct usage of semantic HTML5 elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various accessibility improvements, e.g.:
main,nav)idandfor)Note: I've just extracted the most important changes from our Q2A instance which can be found at https://github.com/wbt-vienna/question2answer
Important: I've not tested this with all the standard Q2A Themes, most likely this PR will break some things. Possibly it makes sense to extract smaller changes and PRs and to not merge this big PR.
We're using Question2Answer on q2a.asterics-foundation.org with Donut theme. There I've also made some changes regarding accessibility which can be found in this PR.