Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy_to_branch()appendssubdirto the siteurlwithfs::path(), which collapses the//after the scheme. Aurlofhttps://example.org/demowithsubdir = "v1"ended up ashttps:/example.org/demo/v1, and that value ended up in the built site'spkgdown.yml.The two parts are now joined with a single
/. Only URLs that have a scheme change: for the 56 url/subdir combinations I compared before and after, the old and new values were identical except thathttps:/becamehttps://(schemeless and local-path values are unchanged). Trailing slashes onurland leading/trailing slashes onsubdirare still normalised as before.I did not change the behaviour of appending
subdirtourlat all, since the issue also questions that and it looks like your call.The new test runs
deploy_to_branch(subdir = "v1")against a local bare remote and checks the URLs written topkgdown.ymlon thegh-pagesbranch. It fails without the fix and passes with it. On my machine the rest of the suite gives the same 12 failures on main and on this branch (the quarto article tests, which need the quarto package, plus thebuild_articleerror snapshot, the tutorials test and the figure test).Part of #2816