Repository navigation
Add Tab-WASD Switcher mod v1.1.0 - #3913
achrllrogia45 wants to merge 3 commits into
Conversation
|
Thanks for the submission. Please address the CI failures. |
Renamed twinuiPcshellSymbolHooks to twinuiPcshellHooks to match the expected pattern (<targetModule>Hooks) required by the mod validation CI.
|
aight thanks for the reviewing glad to contribute! |
- Rename to Tab-WASD Switcher to reflect broader scope - Add Win+Tab (Task View) detection via GetWindowBand + window class - Fix stale state bug where WASD could stay active after switcher closed - Add // twinui.pcshell.dll comment for PR validation compliance - Default enableWasd to true, add 200ms Task View polling timer
achrllrogia45
changed the title
achrllrogia45
left a comment
achrllrogia45
left a comment
There was a problem hiding this comment.
adding Win+Tab feature beside Alt+Tab
|
Why did you remove the pull request form with mod authorship? |
| DWORD waitResult = WaitForSingleObject(g_hookThread, 5000); | ||
| if (waitResult == WAIT_TIMEOUT) { | ||
| Wh_Log(L"Warning: Hook thread did not exit in time, terminating"); | ||
| TerminateThread(g_hookThread, 0); |
There was a problem hiding this comment.
TerminateThread is not a safe operation, and it's preferable to avoid it if possible. See:
https://devblogs.microsoft.com/oldnewthing/20150814-00/?p=91811
Is there a reason it was added?
| /* | ||
| - enableWasd: true | ||
| $name: Enable WASD Navigation | ||
| $description: Master switch. When enabled, WASD keys navigate the Alt+Tab and Win+Tab switchers like arrow keys. |
There was a problem hiding this comment.
What does the mod do when this option is disabled? If nothing, then it's not needed since the mod can simply be disabled.
| } | ||
|
|
||
| // Update Task View visibility state. Called periodically from the hook thread. | ||
| void UpdateTaskViewState() { |
There was a problem hiding this comment.
You have hooks in place. Why is it also necessary for this to be called periodically?
Add AltTab WASD mod - Use WASD keys to navigate the Alt+Tab switcher.
This mod adds WASD navigation to the Alt+Tab and Win+Tab switcher so W, A, S, and D behave
like the Up, Left, Down, and Right arrow keys while the switcher is visible.
It also supports a configurable runtime toggle hotkey. Enable the feature in the
settings, then press the configured hotkey to turn WASD navigation on or off by
keep holding Alt after Alt+Tab while holding Alt continue pressing Ctrl+Shift+"\ (backslash)"
without restarting Explorer.
Changelog
Mod authorship
This mod was created by: