Skip to content

Add leaf workspace quality coverage contract - #1780

Draft
simple-agent-manager[bot] wants to merge 2 commits into
sam/coordinate-implement-deterministic-runtime-gkq1xtfrom
sam/implement-leaf-workspace-lint-pxqaze
Draft

Add leaf workspace quality coverage contract#1780
simple-agent-manager[bot] wants to merge 2 commits into
sam/coordinate-implement-deterministic-runtime-gkq1xtfrom
sam/implement-leaf-workspace-lint-pxqaze

Conversation

@simple-agent-manager

Copy link
Copy Markdown
Contributor

Summary

  • add leaf lint scripts for apps/www, apps/tail-worker, packages/cloud-init, infra, and tools/og-image
  • add explicit apps/www Astro template diagnostics via astro check with fail-closed missing-dependency guard
  • add scoped tools/og-image TypeScript validation
  • add deterministic workspace coverage contract test and fixtures that enumerate pnpm workspaces and fail clearly for uncovered TS/Astro workspaces

Base / Scope

Base branch: sam/coordinate-implement-deterministic-runtime-gkq1xt

Child ownership respected: this PR only changes the assigned leaf manifests plus scripts/quality/workspace-quality-coverage.test.ts and fixtures/workspace-quality-coverage/**. It does not edit root package.json, pnpm-lock.yaml, pnpm-workspace.yaml, root lint config, turbo.json, workflows, shared catalogs, or runtime/template/style files.

Re-audited coverage inventory

Tracked TS-family/Astro files counted with git ls-files for .ts/.tsx/.mts/.cts/.astro: 2,433 total.

Five current gap workspaces: 76 files total:

  • apps/www: 44 (12 TS, 32 Astro)
  • apps/tail-worker: 4 TS
  • packages/cloud-init: 5 TS
  • infra: 20 TS
  • tools/og-image: 3 TS

Validation

  • PASS: pnpm exec vitest run --config scripts/quality/vitest.config.ts scripts/quality/workspace-quality-coverage.test.ts
  • PASS: pnpm --filter @simple-agent-manager/www lint
  • PASS: pnpm --filter @simple-agent-manager/tail-worker lint
  • PASS: pnpm --filter @simple-agent-manager/cloud-init lint
  • PASS: pnpm --filter @simple-agent-manager/infra lint
  • PASS: pnpm --filter @simple-agent-manager/og-image lint
  • PASS: pnpm --filter @simple-agent-manager/tail-worker typecheck
  • PASS: pnpm --filter @simple-agent-manager/cloud-init typecheck
  • PASS: pnpm --filter @simple-agent-manager/infra typecheck
  • PASS: pnpm --filter @simple-agent-manager/og-image typecheck
  • EXPECTED FAIL-CLOSED: CI=1 pnpm --filter @simple-agent-manager/www typecheck reports @astrojs/check is required. This is coordinator-owned dependency/catalog/lockfile wiring.
  • PASS: git diff --check

Coordinator integration required

  • Add @astrojs/check for apps/www Astro template diagnostics, with catalog/lockfile wiring owned by the coordinator.
  • Wire the new contract test into the coordinator-owned root quality command/CI if desired; this child PR only adds the test file.
  • Wire root/turbo integration for the new leaf scripts from the coordinator lane.

Specialist Review Evidence

Reviewer Status Outcome
task-completion-validator PASS Scoped diff covers requested leaf scripts and deterministic contract test; apps/www dependency gap is explicitly fail-closed and documented for coordinator integration.
test-engineer PASS Contract test includes live workspace enumeration plus fixtures for missing lint, Astro tsc-only failure, and covered workspace success.
constitution-validator PASS No runtime business logic, URLs, timeouts, limits, or deployment identifiers added. Fixture constants are static test data only.

Staging

Not run. User explicitly instructed this child lane to never deploy staging.

@codspeed-hq

codspeed-hq Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing sam/implement-leaf-workspace-lint-pxqaze (86ebda4) with main (8c689a6)1

Open in CodSpeed

Footnotes

  1. No successful run was found on sam/coordinate-implement-deterministic-runtime-gkq1xt (21e507a) during the generation of this report, so main (8c689a6) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sonarqubecloud

sonarqubecloud Bot commented Aug 9, 2026

Copy link
Copy Markdown

@simple-agent-manager
simple-agent-manager Bot force-pushed the sam/coordinate-implement-deterministic-runtime-gkq1xt branch from 5863929 to 86be87c Compare August 10, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant