Update pins: openssl>=3.6.1, wheel>=0.46.2#844
Conversation
|
Current tar version is 1.35: https://github.com/conda-forge/tar-feedstock - not sure where you are getting your version from |
jameslamb
left a comment
There was a problem hiding this comment.
We're discussing this offline.
jameslamb
left a comment
There was a problem hiding this comment.
Please see my suggestions on changing how we implement this. And please update the description to match the changes (there are no tar changes in this PR, and "CVE" should be capitalized or omitted completely).
jameslamb
left a comment
There was a problem hiding this comment.
Thanks, this is getting closer. Please see my new round of suggestions.
And then before we merge this, we'll want to double-check some of the images to confirm they have the versions we want. You can find the image URIs for images built from PRs in the logs or by looking at https://hub.docker.com/r/rapidsai/stagin
jameslamb
left a comment
There was a problem hiding this comment.
Looks good! Hope you don't mind, I've updated the title to be a bit easier to understand from the perspective of a user reading the changelog. I think they are more likely to care about the new versions, not that we happened to use conda-meta/pinning to accomplish it.
| @@ -0,0 +1,2 @@ | |||
| openssl >=3.6.1 | |||
| wheel >=0.46.2 | |||
There was a problem hiding this comment.
I do see this pinning being recognized by conda / mamba, great!
I think this is working. I'll type out here how I tested this (I didn't see any comments about whether you had tested, so I double-checked).
Using this build-rapids job: https://github.com/rapidsai/docker/actions/runs/21526839481/job/62032591313?pr=844
conda / mamba recognize the pinning:
#36 13.32 Pinned packages:
#36 13.32
#36 13.32 - openssl>=3.6.1
#36 13.32
#36 13.32 Pinned packages:
#36 13.32
#36 13.32 - wheel>=0.46.2
However, those packages don't show up in any of the environment output. Like this:
#36 37.29 Package Version Build Channel Size
#36 37.29 ───────────────────────────────────────────────────────────────────────────
#36 37.29 Install:
#36 37.29 ───────────────────────────────────────────────────────────────────────────
#36 37.29
#36 37.29 + async-lru 2.1.0 pyhcf101f3_0 conda-forge 19kB
#36 37.29 + babel 2.17.0 pyhd8ed1ab_0 conda-forge 7MB
#36 37.29 + comm 0.2.3 pyhe01879c_0 conda-forge 15kB
#36 37.29 + coverage 7.13.2 py310h3406613_0 conda-forge 313kB
#36 37.29 + dask-glm 0.3.2 pyhd8ed1ab_0 conda-forge 18kB
#36 37.29 + dask-ml 2025.1.0 pyhd8ed1ab_0 conda-forge 114kB
#36 37.29 + debugpy 1.8.20 py310h25320af_0 conda-forge 2MB
#36 37.29 + execnet 2.1.2 pyhd8ed1ab_0 conda-forge 39kB
#36 37.29 + h11 0.16.0 pyhcf101f3_1 conda-forge 39kB
#36 37.29 + httpcore 1.0.9 pyh29332c3_0 conda-forge 49kB
#36 37.29 + httpx 0.28.1 pyhd8ed1ab_0 conda-forge 63kB
#36 37.29 + importlib_resources 6.5.2 pyhd8ed1ab_0 conda-forge 34kB
#36 37.29 + iniconfig 2.3.0 pyhd8ed1ab_0 conda-forge 13kB
#36 37.29 + ipykernel 7.1.0 pyha191276_0 conda-forge 134kB
#36 37.29 + ipywidgets 8.1.8 pyhd8ed1ab_0 conda-forge 114kB
#36 37.29 + json5 0.13.0 pyhd8ed1ab_0 conda-forge 34kB
#36 37.29 + jupyter 1.1.1 pyhd8ed1ab_1 conda-forge 9kB
#36 37.29 + jupyter-lsp 2.3.0 pyhcf101f3_0 conda-forge 60kB
#36 37.29 + jupyter_console 6.6.3 pyhd8ed1ab_1 conda-forge 27kB
#36 37.29 + jupyterlab 4.5.3 pyhd8ed1ab_0 conda-forge 9MB
#36 37.29 + jupyterlab_server 2.28.0 pyhcf101f3_0 conda-forge 52kB
#36 37.29 + jupyterlab_widgets 3.0.16 pyhcf101f3_1 conda-forge 217kB
#36 37.29 + nest-asyncio 1.6.0 pyhd8ed1ab_1 conda-forge 12kB
#36 37.29 + notebook 7.5.3 pyhcf101f3_0 conda-forge 10MB
#36 37.29 + notebook-shim 0.2.4 pyhd8ed1ab_1 conda-forge 17kB
#36 37.29 + patsy 1.0.2 pyhcf101f3_0 conda-forge 193kB
#36 37.29 + prompt_toolkit 3.0.52 hd8ed1ab_0 conda-forge 7kB
#36 37.29 + py-cpuinfo 9.0.0 pyhd8ed1ab_1 conda-forge 26kB
#36 37.29 + pytest 8.4.2 pyhcf101f3_1 conda-forge 295kB
#36 37.29 + pytest-benchmark 5.2.3 pyhd8ed1ab_0 conda-forge 44kB
#36 37.29 + pytest-cov 7.0.0 pyhcf101f3_1 conda-forge 29kB
#36 37.29 + pytest-xdist 3.8.0 pyhd8ed1ab_0 conda-forge 39kB
#36 37.29 + python-louvain 0.16 pyhd8ed1ab_1 conda-forge 15kB
#36 37.29 + seaborn 0.13.2 hd8ed1ab_3 conda-forge 7kB
#36 37.29 + seaborn-base 0.13.2 pyhd8ed1ab_3 conda-forge 228kB
#36 37.29 + sniffio 1.3.1 pyhd8ed1ab_2 conda-forge 16kB
#36 37.29 + sparse 0.17.0 pyhcf101f3_0 conda-forge 121kB
#36 37.29 + statsmodels 0.14.6 py310hf779ad0_0 conda-forge 10MB
#36 37.29 + tomli 2.4.0 pyhcf101f3_0 conda-forge 21kB
#36 37.29 + widgetsnbextension 4.0.15 pyhd8ed1ab_0 conda-forge 889kB
That's ok, they might have just been pre-installed and then not need to be updated. Checked by listing the entire environment.
Pulling that image:
docker run \
--rm \
-it rapidsai/staging:docker-notebooks-844-26.02a-cuda13-py3.10-amd64 \
bashThose are installed and with new-enough versions.
$ conda env list
# conda environments:
#
# * -> active
# + -> frozen
base * /opt/conda
$ conda env export | grep -i -E 'ssl|wheel'
- openssl=3.6.1=h35e630c_1
- wheel=0.46.3=pyhd8ed1ab_0|
Unsure what happened here, but CI is stuck waiting for a job called
The one triggered on PRs is called
I think maybe the problem here is that the branch protection for
While the one for PRs targeting
I can see on the most recent PR merged here (#843, 4 days ago, targeting
I've manually updated the |





No description provided.