vc4 hdmi fixes for packet RAM being disabled#7431
Merged
Merged
Conversation
The user of the packet_ram_enabled was removed, but the flag itself wasn't. Clean up. Fixes: b47a72f ("drm/vc4: hdmi: Switch to HDMI connector") Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
reviewed
Jun 11, 2026
Audio can be triggered by the HPD handler and start up before video has been restored, calling vc4_hdmi_write_infoframe for the audio infoframe. vc4_hdmi_write_infoframe checks that the packet RAM to store the infoframes is enabled, but that is only enabled when video is enabled in vc4_hdmi_encoder_post_crtc_enable. The packet RAM enable is only a power saving thing, so move enabling/disabling to the runtime_pm hooks. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
approved these changes
Jun 11, 2026
Contributor
Author
|
Probably worth deferring merging to confirm that this fixes the original report. |
Contributor
Author
Original reporter has said this fixes his test case. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 16, 2026
See: raspberrypi/linux#7430 kernel: drm/gem-framebuffer: Don't validate buffer size when non-linear See: raspberrypi/linux#7427 kernel: watchdog: bcm2835: Clamp timeouts to the h/w max See: raspberrypi/linux#7432 kernel: vc4 hdmi fixes for packet RAM being disabled See: raspberrypi/linux#7431 kernel: Fixup CFE and Unicam RGB/BGR888 handling See: raspberrypi/linux#7406 kernel: arm64: errata: Mitigate TLBI errata on various Arm CPUs See: raspberrypi/linux#7429 kernel: pwm: pio-rp1: don't flag driver as using atomic ops See: raspberrypi/linux#7439
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jun 16, 2026
See: raspberrypi/linux#7430 kernel: drm/gem-framebuffer: Don't validate buffer size when non-linear See: raspberrypi/linux#7427 kernel: watchdog: bcm2835: Clamp timeouts to the h/w max See: raspberrypi/linux#7432 kernel: vc4 hdmi fixes for packet RAM being disabled See: raspberrypi/linux#7431 kernel: Fixup CFE and Unicam RGB/BGR888 handling See: raspberrypi/linux#7406 kernel: arm64: errata: Mitigate TLBI errata on various Arm CPUs See: raspberrypi/linux#7429 kernel: pwm: pio-rp1: don't flag driver as using atomic ops See: raspberrypi/linux#7439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7069