fix: resolve HTML minifier warnings in strict build#2384
Open
poissoncorp wants to merge 1 commit intoravendb:mainfrom
Open
fix: resolve HTML minifier warnings in strict build#2384poissoncorp wants to merge 1 commit intoravendb:mainfrom
poissoncorp wants to merge 1 commit intoravendb:mainfrom
Conversation
- Strip <?xml?> declarations from 15 SVG icons and add defensive strip in Icon component's getSvg() to prevent future occurrences - Remove control characters (0x0B) from Kubernetes operator guide - Fix invalid <p> nesting in certificate-configuration by removing standalone <TabItem> wrappers (used without <Tabs>) and separating inline <Admonition> from surrounding text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional description
Resolves all build warnings emitted during
DOCUSAURUS_STRICT=truebuilds.Changes
"Unexpected question mark instead of tag name"
<?xml ...?>declarations from 15 SVG files instatic/icons/.replace()inIcon.tsx'sgetSvg()to strip XMLdeclarations before injecting SVG content via
dangerouslySetInnerHTML"Control character in input stream"
0x0B) with spaces inguides/the-ravendb-kubernetes-operator-way.mdx"No p element in scope but a p end tag seen"
<TabItem>wrappers per file incertificate-configuration.mdx(current, 6.2, 7.1) — these were usedwithout any
<Tabs>parent, so they were not rendering as tabsTabs/TabItemimports<Admonition>from preceding paragraph text with ablank line to prevent the block-level element from breaking
<p>scopeType of change
/templatesor readme)Changes in docs URLs
/scripts/redirects.jsonfile, setDocuments MovedPR label)Changes in UX/UI