Skip to content

feat: move sdk members#1418

Open
rohanchkrabrty wants to merge 2 commits intomove-sdk-generalfrom
move-sdk-members
Open

feat: move sdk members#1418
rohanchkrabrty wants to merge 2 commits intomove-sdk-generalfrom
move-sdk-members

Conversation

@rohanchkrabrty
Copy link
Contributor

Summary

Decouple the Members page components from TanStack Router, following the same pattern established with the General page migration.

Changes

  • Created standalone view components in react/views/members/:
    • members-page.tsx — Self-contained MembersPage with state-based invite and remove dialogs; accepts optional title/description props
    • invite-member-dialog.tsx — Prop-controlled InviteMemberDialog (open/onOpenChange)
    • remove-member-dialog.tsx — Prop-controlled RemoveMemberDialog (open/onOpenChange/memberId/invited)
    • member-columns.tsxgetColumns takes an onRemoveMember callback instead of using useNavigate
    • member-types.ts, members.module.css, index.ts — Supporting files moved to views
  • Reduced components/organization/members/index.tsx to a thin wrapper importing MembersPage
  • Removed inviteMemberRoute and removeMemberRoute child routes from routes.tsx
  • Deleted old component files (invite.tsx, MemberRemoveConfirm.tsx, member.columns.tsx, member.types.tsx, members.module.css) — no longer imported

Technical Details

  • Invite and remove modals converted from route-based (Outlet on /modal, /remove-member/$memberId/$invited) to state-based (useState + prop-controlled dialogs)
  • MembersActions column component now receives onRemoveMember callback instead of calling useNavigate directly
  • Removed useRouterState route-detection pattern — refetch now triggers on dialog close via callbacks
  • All TanStack Router imports (useNavigate, useParams, useRouterState, Outlet) removed from view components

@rohanchkrabrty rohanchkrabrty self-assigned this Feb 25, 2026
@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Feb 25, 2026 11:57am

@rohanchkrabrty rohanchkrabrty requested review from paanSinghCoder, rohilsurana and rsbh and removed request for paanSinghCoder February 25, 2026 11:57
@rohanchkrabrty rohanchkrabrty changed the base branch from main to move-sdk-general February 25, 2026 12:00
@rohanchkrabrty rohanchkrabrty added the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Feb 25, 2026
@rohanchkrabrty rohanchkrabrty changed the title Move sdk members feat: move sdk members Feb 25, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant