Use strict equality/inequality operator & use const/let over var#228
Open
prajwalkulkarni wants to merge 1 commit into
Open
Use strict equality/inequality operator & use const/let over var#228prajwalkulkarni wants to merge 1 commit into
prajwalkulkarni wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the polyfill uses equality/inequality operators that only compare the underlying values of two operands and don't check their types. Using strict equality/inequality operators enhances the code as even the types of operands are checked.
The current implementation also uses
varfor declaring variables in contrast to usingletandconst. Since the polyfill is transpiled, it is safe to useletandconstovervar.