Skip to content

xplat/js/react-native-github/packages/react-native/Libraries/Settings/RCTSettingsManager.mm #57827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meta-codesync wants to merge 1 commit into from
+3 −2
Closed

xplat/js/react-native-github/packages/react-native/Libraries/Settings/RCTSettingsManager.mm #57827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react-native/Libraries/Settings/RCTSettingsManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ - (void)userDefaultsDidChange:(NSNotification *)note
* Set one or more values in the settings.
* TODO: would it be useful to have a callback for when this has completed?
*/
RCT_EXPORT_METHOD(setValues : (NSDictionary *)values)
- (void)setValues:(NSDictionary *)values
{
_ignoringUpdates = YES;
[values enumerateKeysAndObjectsUsingBlock:^(NSString *key, id json, BOOL *stop) {
Expand All @@ -98,8 +98,9 @@ - (void)userDefaultsDidChange:(NSNotification *)note
/**
* Remove some values from the settings.
*/
RCT_EXPORT_METHOD(deleteValues : (NSArray<NSString *> *)keys)
- (void)deleteValues:(NSArray *)keysRaw
{
NSArray<NSString *> *keys = [RCTConvert NSStringArray:keysRaw];
_ignoringUpdates = YES;
for (NSString *key in keys) {
[_defaults removeObjectForKey:key];
Expand Down
Loading