Open
Conversation
|
|
||
|
|
||
| // Map profile and name to priority | ||
| val sourcePriorityCache: HashMap<Int, HashMap<String, Int>> = hashMapOf() |
Collaborator
There was a problem hiding this comment.
This should be a ConcurrentHashMap for better thread safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code contains redundant sortLinks and toDisplayLink calls and it could be made more efficient, but that would increase code complexity. The caches in QualityDataHelper.kt reduces sortLinks runtime to 0-2ms even with 200 links.
Admittedly the code is quite messy but I could not make it better. Suggestions welcome.