Fix MotionEvent gestures getting stuck in player#2629
Merged
fire-light42 merged 1 commit intorecloudstream:masterfrom Apr 8, 2026
Merged
Fix MotionEvent gestures getting stuck in player#2629fire-light42 merged 1 commit intorecloudstream:masterfrom
fire-light42 merged 1 commit intorecloudstream:masterfrom
Conversation
Fixes: * 2x speed sometimes gets stuck enabled * Zoom frame outline gets stuck on even when not touching screen anymore * Swipe to fast forward time stamp gets stuck visible on the screen even when gesture has completed That is fixed by handling `ACTION_CANCEL` which can sometimes get called instead of ever calling `ACTION_UP` or `ACTION_POINTER_UP`. For zoom, it also adds a check if `lastPan` is not null to run those actions because when `ACTION_CANCEL` is triggered there, `event.pointerCount` is not always two. If there is a `lastPan` we can just run it like normal since that means it is still active and we should run those events, in order to stop the action.
|
Can smb just sdd disable zoom already bro😭🤦🏾♂️ |
Collaborator
An option to disable the zoom gesture would be a great first issue! I want to keep options to a minimum but such an option makes sense. |
Collaborator
|
Good catch with this bug fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
That is fixed by handling
ACTION_CANCELwhich can sometimes get called instead of ever callingACTION_UPorACTION_POINTER_UP. For zoom, it also adds a check iflastPanis not null to run those actions because whenACTION_CANCELis triggered there,event.pointerCountis not always two. If there is alastPanwe can just run it like normal since that means it is still active and we should run those events, in order to stop the action.