Skip to content

Promote AcraApplication deprecations to error level#2630

Draft
Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Luna712:acraapplication-error-level
Draft

Promote AcraApplication deprecations to error level#2630
Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Luna712:acraapplication-error-level

Conversation

@Luna712
Copy link
Copy Markdown
Contributor

@Luna712 Luna712 commented Apr 8, 2026

I know this is really early, but I personally PRed replacements for these to every single repo that used AcraApplication and listed in recloudstream/cs-repos. Therefore to make it less likely something starts using it again, I would prefer to do this earlier now, since it only affects build, not runtime.

If you decide you don't want to yet that is understandable, and this can be closed.

I am still marking this is draft for about another day or two though (maybe a little longer if it takes longer for at least the actively maintained repos to merge my PRs, most already have though)

I know this is really early, but I personally PRed replacements for these to ever single repo that used AcraApplication and listed in recloudstream/cs-repos. Therefore to make it less likely something starts using it again, I would prefer to do this earlier now, since it only affects build, not runtime.
@fire-light42
Copy link
Copy Markdown
Collaborator

fire-light42 commented Apr 8, 2026

These are good changes, but I still want at the very least a week of waiting, maybe even a month before marking as errors in builds.

Changes from upstream which force abrupt code changes are very irritating and I really want to lessen that feeling as much as possible. Making pull requests to various repositories to address this is great!

I think the risk of new AcraApplication usage after the deprecation is less than the risk/irritation of abrupt changes, which is why I want to wait so long.

With the now large backlog of pull requests I think this can stay opened while I review them.

@Luna712
Copy link
Copy Markdown
Contributor Author

Luna712 commented Apr 8, 2026

That is absolutely fair and makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants