Conversation
app/src/main/java/com/lagradost/cloudstream3/utils/videoskip/TheIntroDBSkip.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/utils/videoskip/TheIntroDBSkip.kt
Outdated
Show resolved
Hide resolved
| val season = episode.season ?: return null | ||
| "$mainUrl/v2/media?$idSuffix&season=$season&episode=${episode.episode}" | ||
| } | ||
| val root = app.get(url).parsed<Root>() |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
||
| companion object { | ||
| private val skipApis: List<SkipAPI> = listOf(AniSkip(), IntroDbSkip()) | ||
| private val skipApis: List<SkipAPI> = listOf(AniSkip(), TheIntroDBSkip(), IntroDbSkip()) |
There was a problem hiding this comment.
Hmm. Probably not for this PR in particular, but something I noticed is IntroDB is more particular about what it has, TIDB has more an often more accurate, but some things have start timestamps on TIDB but not IntroDB while having end timestamps on IntroDB but not TIDB. I wander if there is a way to mix what API it can get for different SkipStamp types...
Otherwise perhaps IntroDB should be tried first here since its smaller what it does have may in fact be better than TIDB at times...?
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Works very well on what I tested (I tested on ones that have all the timestamps (Except Preview, one probably exists but I couldnt fine any), and tested on at least one for: TV Series, Anime, Movie, and AsianDrama versions). Only those other suggestions to think about for the future. I am not convinced that OOM was related to this or the SkipAPI at all, it hasnt happened since anyway.
UPDATE Found one with Preview and it works as well.
2 participants
This was a quick 20min coding adventure implementing #2622 Also fixed some issues I found in the existing API.