Enhance CRD check to detect CRDs in subcharts and all locations#587
Open
acornett21 wants to merge 1 commit into
Open
Enhance CRD check to detect CRDs in subcharts and all locations#587acornett21 wants to merge 1 commit into
acornett21 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! A maintainer will review this pull request and trigger functional testing by adding the ok-to-test label. This comment was auto-generated by GitHub Actions. |
Member
|
@acornett21 You should be okay to rebase this now. |
4915011 to
a358a4c
Compare
Signed-off-by: Adam D. Cornett <adc@redhat.com>
a358a4c to
eda3533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the
not-contains-crdscheck to comprehensively detect CustomResourceDefinitions across all possible chart locations:/crdsdirectories/templatesdirectorykind: "CustomResourceDefinition")Previously, the check only examined the main chart's
/crdsdirectory, missing CRDs in subcharts and alternative locations.Testing
Unit Tests
Added 5 new test cases with corresponding test charts:
/templatesdirectory/chartssubdirectory/crdsdirectoryAll 7 total test cases pass (2 existing + 5 new).
Full Index Validation
Verified against the entire OpenShift Helm Charts index using
scripts/verify-all-charts.sh:iax-operator-crd-rh)🤖 Generated with Claude Code