Skip to content

ci: run all jobs unconditionally, remove change detection#2947

Draft
michaeldwan wants to merge 3 commits intomainfrom
md/ci-runs-everything
Draft

ci: run all jobs unconditionally, remove change detection#2947
michaeldwan wants to merge 3 commits intomainfrom
md/ci-runs-everything

Conversation

@michaeldwan
Copy link
Copy Markdown
Member

CI was skipping jobs based on which files changed -- including on pushes to main. A Rust-only commit would skip Go tests, Python lint, etc., so cross-language regressions go undetected and main isn't a reliable known-good baseline.

Ripped out the change detection job entirely. Every CI job now runs on every trigger. If CI time becomes a problem on PRs later, we can add selective skipping back -- but only for PRs, never for main.

Also fixes three pre-existing bugs in the ci-complete gate where version-check, build-cog, and fuzz-go results were never checked, so failures were silently ignored.

CI was skipping jobs based on which files changed -- including on pushes
to main. A Rust-only commit would skip Go tests, Python lint, etc. This
means regressions from cross-language interactions go undetected and main
isn't a reliable known-good baseline.

Remove the change detection job entirely. Every CI job now runs on every
trigger (push, PR, merge group). The setup job remains as a minimal shim
to pass SUPPORTED_PYTHONS to matrix jobs (env context isn't available in
strategy.matrix).

Also fixes two pre-existing bugs in the ci-complete gate: version-check,
build-cog, and fuzz-go results were never checked, so failures in those
jobs were silently ignored.
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 15, 2026

I'm Bonk, and I've done a quick review of your PR.

This PR removes CI change detection so all jobs run unconditionally, and fixes three bugs in the ci-complete gate where version-check, build-cog, and fuzz-go results were never being checked.

The changes look correct - the ci-complete job now properly lists all required jobs in its needs: section, and the shell script checks all their results including the previously missing three. No change detection logic remains.

LGTM

github run

…conditionally

errcheck violations (unchecked error returns on Cleanup, RemoveAll,
Close, Cmd.Run) and gocritic octal literal style (0644 -> 0o644).
These were introduced in #2942 and went undetected because CI skipped
Go lint when only Go files in tools/ changed.
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 15, 2026

I'm Bonk, and I've done a quick review of your PR.

This PR removes CI change detection so all jobs run unconditionally, and fixes three bugs in the ci-complete gate where version-check, build-cog, and fuzz-go results were never being checked.

The changes look correct - the ci-complete job now properly lists all required jobs in its needs: section, and the shell script checks all their results including the previously missing three. No change detection logic remains.

LGTM

github run

More gocritic (octal literals, if-else chains), gosec (SSRF false
positives on hardcoded GitHub/PyPI URLs), modernize (maps.Copy,
strings.SplitSeq, built-in min), and misspell fixes.
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 16, 2026

I reviewed the CI workflow changes in .github/workflows/ci.yaml to verify that the PR properly removes file-based change detection so all jobs run unconditionally, and that the ci-complete gate now correctly includes all 20 required jobs including the previously missing version-check, build-cog, and fuzz-go checks. The changes ensure reliable CI runs on every trigger and prevent silent failures in the completion gate.

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant