ci: run all jobs unconditionally, remove change detection#2947
ci: run all jobs unconditionally, remove change detection#2947michaeldwan wants to merge 3 commits intomainfrom
Conversation
CI was skipping jobs based on which files changed -- including on pushes to main. A Rust-only commit would skip Go tests, Python lint, etc. This means regressions from cross-language interactions go undetected and main isn't a reliable known-good baseline. Remove the change detection job entirely. Every CI job now runs on every trigger (push, PR, merge group). The setup job remains as a minimal shim to pass SUPPORTED_PYTHONS to matrix jobs (env context isn't available in strategy.matrix). Also fixes two pre-existing bugs in the ci-complete gate: version-check, build-cog, and fuzz-go results were never checked, so failures in those jobs were silently ignored.
|
I'm Bonk, and I've done a quick review of your PR. This PR removes CI change detection so all jobs run unconditionally, and fixes three bugs in the The changes look correct - the LGTM |
…conditionally errcheck violations (unchecked error returns on Cleanup, RemoveAll, Close, Cmd.Run) and gocritic octal literal style (0644 -> 0o644). These were introduced in #2942 and went undetected because CI skipped Go lint when only Go files in tools/ changed.
|
I'm Bonk, and I've done a quick review of your PR. This PR removes CI change detection so all jobs run unconditionally, and fixes three bugs in the The changes look correct - the LGTM |
More gocritic (octal literals, if-else chains), gosec (SSRF false positives on hardcoded GitHub/PyPI URLs), modernize (maps.Copy, strings.SplitSeq, built-in min), and misspell fixes.
|
I reviewed the CI workflow changes in |
CI was skipping jobs based on which files changed -- including on pushes to main. A Rust-only commit would skip Go tests, Python lint, etc., so cross-language regressions go undetected and main isn't a reliable known-good baseline.
Ripped out the change detection job entirely. Every CI job now runs on every trigger. If CI time becomes a problem on PRs later, we can add selective skipping back -- but only for PRs, never for main.
Also fixes three pre-existing bugs in the ci-complete gate where
version-check,build-cog, andfuzz-goresults were never checked, so failures were silently ignored.