Skip to content

Conversation

@cknitt
Copy link
Member

@cknitt cknitt commented Jan 4, 2026

Fixes #8138

.build();

log::set_max_level(log_level_filter);
log::set_boxed_logger(Box::new(SplitLogger {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there is no better way with env_logger.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 4, 2026

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8147

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8147

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8147

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8147

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8147

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8147

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8147

commit: 368d110

@nojaf
Copy link
Member

nojaf commented Jan 5, 2026

Regardless of what bsb does, can you elaborate why this is better or what problem this solved?

@cknitt
Copy link
Member Author

cknitt commented Jan 5, 2026

It is standard behavior of Unix CLI tools to write output to stdout and errors to stderr, allowing for separate redirection of output stream and error stream.

So as a user I would expect that behavior, and I would expect a very good reason for deviation, especially if the old build system followed standards here.

@cknitt
Copy link
Member Author

cknitt commented Jan 5, 2026

If this needs further discussion, can we at least move on with #8144 and #8146 in the meantime?

@cknitt cknitt merged commit d04afe6 into rescript-lang:master Jan 6, 2026
25 checks passed
@cknitt cknitt deleted the rewatch-stderr branch January 6, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewatch logs (most?) errors to stdout instead of stderr

3 participants