Skip to content

normalisation suppressed if 1 entity is missing :id #25

Description

@stevebuik

this works as expected

(->> {:id   "100"
            :name "Steve"
            :cars [{:id          "123"
                    :name        "Audi"}
                   {
                    :id          "124" ; <<<<< comment/remove this line
                    :name        "Ford"}
                   {:id          "125"
                    :name        "Tesla"}]}
           dx/normalize)

but if one of the cars has no id, the none of the cars are normalised.

is this intentional?

it would be better for dev/debug if the valid cars were still normalised.

maybe a log msg could indicate that one was skipped? not sure how log tooling works and if that's something you consider desirable?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions