feat: pivot click to add filter in canvas#8951
Merged
Merged
Conversation
Collaborator
|
Some UXQA items before I do a code review,
|
Member
Author
|
This will need some more re-work based on https://www.notion.so/rilldata/Click-to-Filter-31bba33c8f57807189f0dd685498438f |
AdityaHegde
reviewed
May 15, 2026
| // (extractDimensionFiltersFromExpression, getActiveDimensionNames, etc.) | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| vi.mock( |
Collaborator
There was a problem hiding this comment.
Why are we mocking theses? There doesnt seem to be tests for them specifically so would be good to let them work as is. Same for pivot-row-selection.
Member
Author
There was a problem hiding this comment.
The mocks make the setup and orchestration easy. Using the real functions would involve complex real world pivot table setup. The current tests focus on the click selection logic specifically. A broader real world test suite can be a follow up for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/rilldata/issue/APP-770/click-to-filter-for-pivot-and-table-component
Adds click to filter for pivot and flat table in canvas
Checklist: