Skip to content

Per slot disk configuration in the helm charts #9448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himadrisingh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Per slot disk configuration in the helm charts #9448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69bbcba
Per slot disk configuration
himadrisingh May 14, 2026
a218bde
Update kubernetes.go
himadrisingh May 14, 2026
5da43f3
Apply suggestion from @himadrisingh
himadrisingh May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/provisioner/kubernetes/kubernetes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func (p *KubernetesProvisioner) Provision(ctx context.Context, r *provisioner.Re
host := p.getHost(provisionID)

// Compute storage. If an override is provided on the project, it takes precedence over the slot-based default.
storageBytes := 40 * int64(args.Slots) * int64(datasize.GB)
storageBytes := int64(args.Slots) * int64(datasize.GB)
Copy link
Copy Markdown
Contributor

@begelundmuller begelundmuller May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing something? Having slots to GB be 1:1 doesn't seem so useful to me (very little disk) and will be problematic for many current users

Copy link
Copy Markdown
Contributor Author

@himadrisingh himadrisingh May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are trying move it to helm charts so its easily configurations

Copy link
Copy Markdown
Contributor Author

@himadrisingh himadrisingh May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently we are dividing it by 1/2 in helm charts

if args.OverrideDiskGB != nil && *args.OverrideDiskGB > 0 {
storageBytes = *args.OverrideDiskGB * int64(datasize.GB)
}
Expand Down
Loading