temp: patch wasm-pack to point to latest binary#5037
Conversation
|
PR Review for PR 5037 (temp: patch wasm-pack) Overview: Patches wasm-pack@0.14.0 to fix its binary download URL (moved from drager to wasm-bindgen org), bumps from 0.13.1 to 0.14.0, and disables the build-wasm CI job. ISSUE 1 - Stale pnpm-lock.yaml override (bug): package.json removed the wasm-pack entry from overrides, but pnpm-lock.yaml line 26 still reads wasm-pack: =0.13.1. The lock file also retains a wasm-pack@0.13.1 snapshot near line 17998. Run pnpm install and recommit the updated lock file. ISSUE 2 - Commented-out CI job leaves dead code: The entire build-wasm job is commented out in publish.yaml rather than deleted. If temporary, add an inline comment explaining the condition to re-enable. If the wasm package is no longer published, delete the job and remove references to rivetkit-typescript/packages/rivetkit-wasm/pkg from downstream steps. ISSUE 3 - Missing newline at end of package.json: The diff shows No newline at end of file. Add a trailing newline. CONCERN - Supply chain: The patch redirects binary downloads from github.com/drager/wasm-pack to github.com/wasm-bindgen/wasm-pack. This appears correct given the project transferred orgs, but confirm the new release URL resolves to the expected artifact before merging. CONCERN - Patch fragility: Patching binary.js is a reasonable short-term workaround. Once wasm-pack ships an npm release with the corrected URL, this patch and the patchedDependencies entry can be dropped. Summary: The core change (patching the download URL) is the right approach. Three things to fix before merging: regenerate the lock file to remove the stale =0.13.1 override, add a trailing newline to package.json, and either delete the commented-out build-wasm job or add a note explaining when to restore it. |
e872ef5 to
d644728
Compare
d644728 to
abf9ff9
Compare
8e4c5f6 to
eaa41b2
Compare
abf9ff9 to
40c3589
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: