feat(rivetkit): configure client connection request size#5055
Closed
rockorager wants to merge 2 commits into
Closed
feat(rivetkit): configure client connection request size#5055rockorager wants to merge 2 commits into
rockorager wants to merge 2 commits into
Conversation
The client-side WebSocket connection path rejects oversized action requests before sending them to the actor, but the limit was fixed at the default actor incoming message size. Applications that intentionally raise the actor-side limit could still fail locally because the client had no matching configuration knob. Add maxConnectionRequestSize to the client config and thread it through handles and persistent connections. Keep the name connection-specific because this guard only applies to action requests sent through .connect(), not stateless HTTP actions or raw fetch requests. Map registry maxIncomingMessageSize into internal clients so local runtime-created clients use the same limit as the actor runtime. Document the client-side setting alongside the actor message-size limits.
Contributor
|
#5057 |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
maxConnectionRequestSizeto the RivetKit client config for action requests sent through.connect().Previously, the client rejected serialized connection action requests above 64 KiB before sending them, even when the actor-side
maxIncomingMessageSizewas configuredhigher. This adds a connection-specific client knob and documents it separately from the server-side WebSocket limits.
Type of change
How Has This Been Tested?
pnpm -F rivetkit test tests/actor-gateway-url.test.tsgit diff --check HEADChecklist: