Skip to content

Optimize proof memory#1097

Open
0xfornax wants to merge 1 commit intomasterfrom
optimize-proof-memory
Open

Optimize proof memory#1097
0xfornax wants to merge 1 commit intomasterfrom
optimize-proof-memory

Conversation

@0xfornax
Copy link
Copy Markdown
Member

@0xfornax 0xfornax commented May 6, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Coverage Report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool/node 0.00% (ø)
github.com/rocket-pool/smartnode/shared/services 0.34% (-0.00%) 👎
github.com/rocket-pool/smartnode/shared/types/eth2 0.00% (ø)
github.com/rocket-pool/smartnode/shared/types/eth2/fork/electra 0.00% (ø)
github.com/rocket-pool/smartnode/shared/types/eth2/fork/fulu 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool/node/stake-megapool-validator.go 0.00% (ø) 1415 0 1415
github.com/rocket-pool/smartnode/shared/services/megapools.go 1.01% (-0.00%) 5142 (+13) 52 5090 (+13) 👎
github.com/rocket-pool/smartnode/shared/services/services.go 0.00% (ø) 1869 (+12) 0 1869 (+12)
github.com/rocket-pool/smartnode/shared/types/eth2/fork/electra/state_electra.go 0.00% (ø) 1744 (+378) 0 1744 (+378)
github.com/rocket-pool/smartnode/shared/types/eth2/fork/fulu/state_fulu.go 0.00% (ø) 1849 (+372) 0 1849 (+372)
github.com/rocket-pool/smartnode/shared/types/eth2/types.go 0.00% (ø) 326 0 326

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@jshufro
Copy link
Copy Markdown
Contributor

jshufro commented May 6, 2026

Pretty smart. Does it work?

You can also consider vectorizing the function- right now we do this one validator index at a time, but there are node operators who have to generate multiple proofs per pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants